-
Notifications
You must be signed in to change notification settings - Fork 1
EN #4304 improvements and cleanup #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aarongoin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good to me. Just have a Q about including lombok in the dependencies. Copying my message from Slack:
My understanding--though admittedly quite flawed--is that lombok is something that's typically provided by one's IDE (for devs using IntelliJ, Eclipse, etc) and is basically just a dev dependency. Did you find you needed it in the built version? Or was this to enable development and local building? I ended up manually installing lombok in my system to enable me to build locally without needing those IDEs.
|
@aarongoin ah that's good to know that it's typically included with java IDEs. Yeah, I added for local builds with vscode, attempting to make the experience smoother. I'll rip it out. |
|
@aarongoin oh wait, I just moved lombok out of each module where it was previously and added to the parent pom so the modules could just inherit it. So we only have one spot to maintain it. Are you saying it shouldn't be included in any modules? |
|
@eneumann Well that was my understanding. lombok is a dev dependency--it shouldn't need to be bundled with the java lib at all. I think historically it wasn't needed or included in the POMs because many Java native IDE's provide a way to use it from within the IDE and so I think that's why Gaston never added it to the POM files. But in my latest reading it appears that the |
EN #4289 prevent name collisions
No description provided.