Skip to content

Conversation

@eneumann
Copy link
Member

No description provided.

@eneumann eneumann requested a review from aarongoin May 20, 2025 23:05
Copy link
Member

@aarongoin aarongoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. Just have a Q about including lombok in the dependencies. Copying my message from Slack:

My understanding--though admittedly quite flawed--is that lombok is something that's typically provided by one's IDE (for devs using IntelliJ, Eclipse, etc) and is basically just a dev dependency. Did you find you needed it in the built version? Or was this to enable development and local building? I ended up manually installing lombok in my system to enable me to build locally without needing those IDEs.

@eneumann
Copy link
Member Author

@aarongoin ah that's good to know that it's typically included with java IDEs. Yeah, I added for local builds with vscode, attempting to make the experience smoother. I'll rip it out.

@eneumann
Copy link
Member Author

@aarongoin oh wait, I just moved lombok out of each module where it was previously and added to the parent pom so the modules could just inherit it. So we only have one spot to maintain it. Are you saying it shouldn't be included in any modules?

@aarongoin
Copy link
Member

@eneumann Well that was my understanding. lombok is a dev dependency--it shouldn't need to be bundled with the java lib at all. I think historically it wasn't needed or included in the POMs because many Java native IDE's provide a way to use it from within the IDE and so I think that's why Gaston never added it to the POM files. But in my latest reading it appears that the <scope>provided</scope> part means Maven considers it a compiler dependency only and shouldn't include it when jarring? So I guess in theory it actually shouldn't hurt anything adding it to the POM like this... In theory! 😜 I suppose we should verify that it's not being included somehow in the final jars just to sanity check... Anyway if we do add it, I like that you've put it in a single place rather than many.

@eneumann eneumann merged commit 31016fb into develop May 23, 2025
1 check passed
@eneumann eneumann deleted the EN_#4304_improvements-and-cleanup branch May 23, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants